-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop caniuse #2296
Drop caniuse #2296
Conversation
5cc60fb
to
a818a45
Compare
aab9acf
to
11999f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A couple comments maybe we should talk about early next week? Going to live it open so we don't forget about them but we should merge this early Monday (feel free to do it yourself).
Also I'm thinking we should link to the video of the PR review in the commit message as a Ref (https://youtu.be/Y94fMxmbMFI). It helped me a lot. What do you think?
@antross there are conflicts with a |
Yep, I'll get this updated shortly. |
Yep, I like that - I'll add it. |
Pull request checklist
Make sure you:
For non-trivial changes, please make sure you also:
Short description of the change(s)
Includes updating all hints which previously used
caniuse-api
to use the newisSupported
helper based on MDN data. Also cutshint-compat-api
over to using the packaged MDN data from@hint/utils
shaving ~30KB off the bundle size (bringing it to ~618KB).I'll leave migrating
hint-compat-api
to the newgetUnsupported
helper for a follow-up PR (which should help simplify that hint significantly).